fix(core): change locale prefix to to prevent caching issues #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 9d84384 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorgemoya
force-pushed
the
fix-locale-switching
branch
2 times, most recently
from
9809090
to
16c7835
Compare
jorgemoya
force-pushed
the
fix-locale-switching
branch
from
16c7835
to
9d84384
Compare
deini
approved these changes
Sep 12, 2024
Closed
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-csffjk8r2-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
When using locale switcher with locale prefix
never, there is a caching issue that prevents the correct messages to show when navigating between pages. There is an open issue about this.This change sets locale prefix to
as-needed, so locale prefix will only be shown if not using the default locale.Testing
Correct messages are shown when locale switching without the need to hard refresh.